track sold out products INREL-3676#101
Conversation
| ->setAttribute('data-uuid', $product->uuid->value) | ||
| ->setAttribute('data-product-id', $product->product_id->value); | ||
| ->setAttribute('data-product-id', $product->product_id->value) | ||
| ->setAttribute('data-sold-out', (string)$product->product_sold_out->value === "1" ? 'true' : 'false'); |
There was a problem hiding this comment.
How about we leave it clean without transforming the data? Something like: ->setAttribute('data-sold-out', (string)$product->product_sold_out->value
| initialize: function (pOptions) { | ||
| BaseView.prototype.initialize.call(this, pOptions); | ||
|
|
||
| if (this.$el.hasClass('item-product--sold-out')) { |
There was a problem hiding this comment.
Not sure why this has to be removed. Can you clarify?
| productCategory: this.model.get('productCategory'), | ||
| containerType: this.model.get('containerType') || '' | ||
| containerType: this.model.get('containerType') || '', | ||
| soldOut: this.$el.attr('data-sold-out') === 'true' |
There was a problem hiding this comment.
Instead of getting the data here we could set the data on the model directly (and also transform data there):
this.model.set('sold-out', this.$el.data('sold-out') === 1 ? 'true' : 'false'). See Line 85.
There was a problem hiding this comment.
Afterwards it's just a simple soldOut: this.model.get('sold-out')
saviomuc
left a comment
saviomuc
left a comment
There was a problem hiding this comment.
I have some small suggestions. Please clarify what value we need to pass: Number (1,0), Boolean or String.
2 participants
No description provided.